set SERIAL on histogram fits to restore deterministic fits #23230
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23230/4701 |
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: DQMServices/ClientConfig @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @slava77, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi @dan131riley Can I identify you as HI Validation DQM developer contact in |
|
please test |
|
The tests are being triggered in jenkins. |
|
@jfernan2 this is strictly in my role in the core software team making the PR tests reproducible, I don't really know anything about the HI DQM |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The DQM comparisons are not what I expected, this will take some more research. Can the tests be re-run to see if they are consistent? |
|
please test
On 18 May 2018, at 02:00, Dan Riley <notifications@github.com<mailto:notifications@github.com>> wrote:
The DQM comparisons are not what I expected, this will take some more research. Can the tests be re-run to see if they are consistent?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23230 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw8rTaMpoULbasCTKOrXQDV8fUQ-zks5tzg8DgaJpZM4UDOuH>.
|
|
The tests are being triggered in jenkins. |
|
On 5/18/18 2:00 AM, Dan Riley wrote:
The DQM comparisons are not what I expected, this will take some more
research. Can the tests be re-run to see if they are consistent?
—
I'm not sure what your expectation is from the jenkins comparisons.
If the baseline is made out of order, then the fixed version will be
different.
all DQM differences are falling under
"_Mean\|_Sigma\|SigmaTest_W\|MeanTest_W\|mean_delta" pattern
OTOH, the 140.53 shows no differences and I had at least one test case
earlier when both the 140.53 and the DQM differences appeared in jenkins
comparisons simultaneously.
Perhaps they are independent though.
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
While the retest showed the same differences as the first test, even that doesn't tell us much as they used different baselines. I agree with @slava77 that this should be merged. |
|
@jfernan2 @dmitrijus could you please check and sign? I agree that we need to merge this PR if we really want to verify that it does what it is supposed to do, and I would like to have it in pre4 if possible, as these differences in tests are quite annoying |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
In ROOT 6.12 with IMT enabled, the chi2 calculation for fits is chunked based on the number of cpus, changing the order of calculations. In some (possibly pathological) cases this can change the results, causing problems for the automated comparisons used for pull requests. This PR sets the SERIAL option on several fits to restore the deterministic ordering from prior to ROOT 6.12. Details are in issue #23105 and see also previous history in PR #22227