Made comparison functions const

[Dr15Jones]

gcc8 requires that comparison functions used in sorted std containers
must be const.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23231/4702

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/HcalObjects

@arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28013/console Started: 2018/05/17 17:41

[Dr15Jones]

@arunhep @cerminar @franzoni @ggovi @lpernie the changes are purely technical.

[arunhep]

+1

[cmsbuild]

+1
Tested at: 00e7e59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23231/28013/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ddf0180
c2cabeb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23231/28013/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23231/28013/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23231/28013/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2356 differences found in the comparisons
• DQMHistoTests: Total files compared: 30
• DQMHistoTests: Total histograms compared: 2740553
• DQMHistoTests: Total failures: 9961
• DQMHistoTests: Total nulls: 10
• DQMHistoTests: Total successes: 2730399
• DQMHistoTests: Total skipped: 183
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.964 KiB( 29 files compared)
• DQMHistoSizes: changed ( 250202.181 ): 1.964 KiB SiStrip/MechanicalView
• Checked 124 log files, 14 edm output root files, 30 DQM output files

[fabiocos]

@ggovi changes looks unrelated to this PR, could you please check and sign in case?

[Dr15Jones]

This is the same as #23224

[Dr15Jones]

@ggovi ping
This should resolve around 7000 errors in the gcc 8 build.

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

Closing it, same as #23224 .