Changes to CalibFormats/SiPixelObjects to fix gcc 8 compiler errors #23233
Conversation
Only a std::dynamic_cast of a reference throws std:bad_cast. This code does not do that.
Switched from sprintf to snprintf and set buffer size to maximum possible size to avoid truncations. This was required by gcc 8.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23233/4704 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CalibFormats/SiPixelObjects @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
+1 the differences look the old known ones |
This avoids potential buffer problems with calls to sprintf as well as removed unnecessary try {} catch block.