Fixed sprintf buffer length problems #23234
Conversation
gcc 8 was issuing errors for the uses of sprintf where the buffer was not long enough to contain the full range of integral values. This change increased the buffer size to match what the compiler found as the maximum theoretical size and changed to using snprintf.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23234/4707 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DataFormats/Scalers @perrotta, @cmsbuild, @emeschi, @nsmith-, @rekovic, @thomreis, @slava77, @mommsen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
gcc 8 was issuing errors for the uses of sprintf where the buffer
was not long enough to contain the full range of integral values.
This change increased the buffer size to match what the compiler
found as the maximum theoretical size and changed to using
snprintf.