Tracking hgh beta star 2018 #23238

robertccms · 2018-05-17T23:32:42Z

This pull includes modified parameters for tracking reconstruction to be used for 2018 joint CMS-TOTEM run at high betaStar. The new era Run2_2018_highBetaStar is created with the highBetaStar_2018 modifier, which changes parameters in 8 python files in RecoTracker/IterativeTracking and 2 files in RecoVertex/PrimaryVertexProducer.

cmsbuild · 2018-05-17T23:35:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-05-17T23:38:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23238/4713

cmsbuild · 2018-05-17T23:39:04Z

A new Pull Request was created by @robertccms for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
RecoTracker/IterativeTracking
RecoVertex/PrimaryVertexProducer

@perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-05-18T04:54:24Z

@cmsbuild please test

cmsbuild · 2018-05-18T04:54:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28025/console Started: 2018/05/18 08:29

makortel

I have two (very) minor comments.

makortel · 2018-05-18T07:10:19Z

RecoTracker/IterativeTracking/python/DetachedQuadStep_cff.py

@@ -70,6 +73,8 @@
    CAThetaCut = 0.0011,
    CAPhiCut = 0,
 )
+highBetaStar_2018.toModify(detachedQuadStepHitQuadruplets,CAThetaCut = 0.0022,CAPhiCut = 0.1,CAHardPtCut = 0.)


CAHardPtCut is 0 by default

cmssw/RecoPixelVertexing/PixelTriplets/plugins/CAHitQuadrupletGenerator.cc

Line 63 in ddf0180

desc.add<double>("CAHardPtCut", 0);

so it would be clearer not to "override" it here (reader my wonder what the default is if it is overridden here).

Hi Matti,

Good comments. Thanks. Technically, who's supposed to make these modifications? Can they be done centrally? Or is any action required from my side?

@robertccms
just remove ,CAHardPtCut = 0. from the list of parameters that you modify

makortel · 2018-05-18T07:20:42Z

RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py

+   ptMin = 0.05,
+   originRadius = cms.double(0.2),
+   originHalfLength=15.0
+))


If the intention is to have the same region settings as for A, it would be clearer to do

highBetaStar_2018.toReplacewith(mixedTripletStepTrackingRegionsB, _mixedTripletStepTrackingRegionsCommon.clone())

Same as above.

@robertccms
just replace your definiton with what @makortel proposes

cmsbuild · 2018-05-18T08:39:41Z

+1
Tested at: 0cbd147
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23238/28025/summary.html

cmsbuild · 2018-05-18T08:39:43Z

Comparison job queued.

cmsbuild · 2018-05-18T10:19:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23238/28025/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 30
DQMHistoTests: Total histograms compared: 2740553
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2740369
DQMHistoTests: Total skipped: 183
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
Checked 124 log files, 14 edm output root files, 30 DQM output files

slava77 · 2018-05-21T11:20:48Z

@robertccms
please suggest a run number where this can be tested at run time

cmsbuild · 2018-05-22T09:17:42Z

+1
Tested at: 86d979a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23238/28096/summary.html

cmsbuild · 2018-05-22T09:17:45Z

Comparison job queued.

cmsbuild · 2018-05-22T11:15:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23238/28096/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2901712
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901521
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

perrotta · 2018-05-22T11:17:12Z

Tested by modifying one of the 2018 data workflow in the matrix with the Run2_2018_highBetaStar era, and the proposed ZeroBias dataset as in #23238 (comment)
The same GT as used in 2018A was used

A few comparisons (100 events; red is the new tracking config for the TOTEM test as in this PR, black is the 2018 tracking config):

Larger efficiency at low track pt:
General tracks algo changes:
Larger number of PF candidates with ID=1:

perrotta · 2018-05-22T12:35:23Z

Number of layers and 3D layers per track:

perrotta · 2018-05-22T12:36:59Z

The number of seeds seems to explode: did you measure the timing for this tracking config?

robertccms · 2018-05-22T14:11:50Z

@perrotta

Yes, the timing was tested, please see slide 4 of https://indico.cern.ch/event/727481/contributions/2994591/attachments/1646577/2631872/CMSTOTEM_tracking_RCmeeting_9May2018_Robert.pdf
(this tune reco in red vs. standard reco in blue)

The increase in number of tracks and seeds in expected for this relaxed set of reco parameters. It designed to run on low-pileup events and reconstruct more low-pT tracks.

perrotta · 2018-05-22T15:57:31Z

To compare with the result presented in #23238 (comment), the timing was measured with 100 events run (reco+miniAOD) single threaded on cmsdev12.
The total CPU timing increase per event in about 20 ms , overall some 5% above the CPU needed for processing the same events with the standard pp 2018 tracking. The relative increase is in line with what was presented in those slides.

Detail:

  delta/mean delta/orJob     original                   new       module name
  ---------- ------------     --------                  ----       ------------
   +1.786631      +0.21%         0.05 ms/ev ->         0.85 ms/ev pixelPairStepSeedsA
   +1.643004      +0.22%         0.09 ms/ev ->         0.92 ms/ev highPtTripletStepHitTriplets
   +1.608680      +0.01%         0.01 ms/ev ->         0.06 ms/ev shiftedPatMuonEnDown
   +1.582603      +0.88%         0.44 ms/ev ->         3.78 ms/ev pixelPairStepTrackCandidates
   +1.499352      +0.03%         0.02 ms/ev ->         0.14 ms/ev mixedTripletStepSeedsA
   +1.446900      +0.07%         0.05 ms/ev ->         0.33 ms/ev mixedTripletStepHitTripletsA
   +1.388645      +0.15%         0.12 ms/ev ->         0.68 ms/ev initialStepHitQuadruplets
   +1.282725      +0.26%         0.28 ms/ev ->         1.27 ms/ev pixelPairStepTracks
   +1.276017      +0.10%         0.10 ms/ev ->         0.46 ms/ev lowPtTripletStepHitTriplets
   +1.254382      +0.07%         0.08 ms/ev ->         0.33 ms/ev pixelPairStep
   +1.203440      +0.06%         0.07 ms/ev ->         0.30 ms/ev caloJetMap
   +1.117644      +0.08%         0.13 ms/ev ->         0.44 ms/ev mixedTripletStepTrackCandidates
   +1.110701      +0.09%         0.14 ms/ev ->         0.50 ms/ev mixedTripletStepTracks
   +1.082796      +0.03%         0.05 ms/ev ->         0.17 ms/ev detachedTripletStepHitTriplets
   +1.057963      +0.03%         0.06 ms/ev ->         0.19 ms/ev pixelPairStepSeedsB
   +1.050031      +0.04%         0.07 ms/ev ->         0.21 ms/ev detachedQuadStepHitQuadruplets
   +1.049304      +0.02%         0.03 ms/ev ->         0.09 ms/ev pfNoPileUpIsoPFBRECO
   +1.029948      +0.02%         0.03 ms/ev ->         0.11 ms/ev mixedTripletStepHitTripletsB
   +1.013793      +0.01%         0.01 ms/ev ->         0.03 ms/ev pixelPairStepSeeds
   +1.003277      +0.01%         0.03 ms/ev ->         0.08 ms/ev mixedTripletStep
   +0.730760      +0.11%         0.37 ms/ev ->         0.79 ms/ev highPtTripletStep
   +0.656459      +0.34%         1.31 ms/ev ->         2.60 ms/ev highPtTripletStepTracks
   +0.608253      +0.46%         2.00 ms/ev ->         3.76 ms/ev highPtTripletStepTrackCandidates
   -0.598134      -0.43%         3.53 ms/ev ->         1.90 ms/ev lowPtQuadStepTrackCandidates
   -0.525068      -0.24%         2.18 ms/ev ->         1.27 ms/ev lowPtQuadStepTracks
   +0.502663      +0.09%         0.50 ms/ev ->         0.83 ms/ev firstStepPrimaryVerticesUnsorted
   +0.488928      +0.12%         0.71 ms/ev ->         1.17 ms/ev siPixelClustersPreSplitting
   +0.421252      +0.40%         2.83 ms/ev ->         4.34 ms/ev initialStepTracks
   +0.416434      +0.29%         2.13 ms/ev ->         3.26 ms/ev unsortedOfflinePrimaryVertices
   +0.403281      +0.59%         4.46 ms/ev ->         6.71 ms/ev initialStepTrackCandidates
   -0.397487      -0.15%         1.69 ms/ev ->         1.13 ms/ev lowPtTripletStepTrackCandidates
   +0.385570      +0.08%         0.65 ms/ev ->         0.96 ms/ev initialStep
   +0.340293      +0.27%         2.47 ms/ev ->         3.48 ms/ev trackExtrapolator
   -0.202100      -0.06%         1.16 ms/ev ->         0.95 ms/ev lowPtTripletStepTracks
  ---------- ------------     --------                  ----       ------------
Job total:  0.381152 s/ev ==> 0.402424 s/ev

robertccms · 2018-05-22T16:25:05Z

@perrotta

that's good. thanks for the confirmation!

perrotta · 2018-05-23T05:38:33Z

+1

Track reconstruction parameters to be used for the 2018 CMS-TOTEM run at large beta*
They are defined in a dedicated era, and therefore do not affect normal reco sequences and workflows
Comparison with the current tracking show a larger acceptance of low pt particles, which is instrumental for the run on low-pileup events and the reconstruction of soft tracks
Overall CPU increase is kind of 5-10% of the total reco time, which is still deemed acceptable for the special runs where this config is required

fabiocos · 2018-05-23T08:27:07Z

+operations

the changes in the StandardSequences are related to the addition of a new era for the high beta* data taking

cmsbuild · 2018-05-23T08:27:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-05-23T08:28:04Z

+1

slava77 · 2018-05-27T16:14:32Z

@robertccms
this PR was merged a few days ago.
What is the status of the 10_1_X backport?

robertccms added 4 commits May 18, 2018 01:04

tracking tune for highBetaStar 2018 run

4912983

tracking tune for highBetaStar 2018 run

11453e2

tracking tune for highBetaStar 2018 run

7b6b6c2

tracking tune for highBetaStar 2018 run

0cbd147

cmsbuild added this to the CMSSW_10_2_X milestone May 17, 2018

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 17, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 17, 2018

cmsbuild added tests-started and removed tests-pending labels May 18, 2018

makortel reviewed May 18, 2018

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels May 18, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 18, 2018

fabiocos mentioned this pull request May 22, 2018

Features needed in CMSSW_10_1_X for 90 m beta* Totem run #23275

Closed

14 tasks

cmsbuild added tests-approved and removed tests-started labels May 22, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 22, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 23, 2018

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels May 23, 2018

cmsbuild added orp-approved and removed orp-pending labels May 23, 2018

cmsbuild merged commit 7b17468 into cms-sw:master May 23, 2018

fabiocos mentioned this pull request May 23, 2018

MTD: ideal geometry based on detailed volume description, numbering scheme, adapt the existing Sim-DIGI-RECO chain to it #23126

Merged

robertccms mentioned this pull request May 28, 2018

Tracking hgh beta star 2018 (101X backport) #23360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking hgh beta star 2018 #23238

Tracking hgh beta star 2018 #23238

robertccms commented May 17, 2018

cmsbuild commented May 17, 2018

cmsbuild commented May 17, 2018

cmsbuild commented May 17, 2018

slava77 commented May 18, 2018

cmsbuild commented May 18, 2018 •

edited

makortel left a comment

makortel May 18, 2018

robertccms May 21, 2018

perrotta May 21, 2018

makortel May 18, 2018

robertccms May 21, 2018

perrotta May 21, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

slava77 commented May 21, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

perrotta commented May 22, 2018

perrotta commented May 22, 2018

perrotta commented May 22, 2018

robertccms commented May 22, 2018

perrotta commented May 22, 2018

robertccms commented May 22, 2018

perrotta commented May 23, 2018

fabiocos commented May 23, 2018

cmsbuild commented May 23, 2018

fabiocos commented May 23, 2018

slava77 commented May 27, 2018

Tracking hgh beta star 2018 #23238

Tracking hgh beta star 2018 #23238

Conversation

robertccms commented May 17, 2018

cmsbuild commented May 17, 2018

cmsbuild commented May 17, 2018

cmsbuild commented May 17, 2018

slava77 commented May 18, 2018

cmsbuild commented May 18, 2018 • edited

makortel left a comment

Choose a reason for hiding this comment

makortel May 18, 2018

Choose a reason for hiding this comment

robertccms May 21, 2018

Choose a reason for hiding this comment

perrotta May 21, 2018

Choose a reason for hiding this comment

makortel May 18, 2018

Choose a reason for hiding this comment

robertccms May 21, 2018

Choose a reason for hiding this comment

perrotta May 21, 2018

Choose a reason for hiding this comment

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

cmsbuild commented May 18, 2018

slava77 commented May 21, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

cmsbuild commented May 22, 2018

perrotta commented May 22, 2018

perrotta commented May 22, 2018

perrotta commented May 22, 2018

robertccms commented May 22, 2018

perrotta commented May 22, 2018

robertccms commented May 22, 2018

perrotta commented May 23, 2018

fabiocos commented May 23, 2018

cmsbuild commented May 23, 2018

fabiocos commented May 23, 2018

slava77 commented May 27, 2018

cmsbuild commented May 18, 2018 •

edited