Fix missing headers in Geometry/HcalCommonData to test boost 1.67

[mrodozov]

Fixes missing headers needed for this test cms-sw/cmsdist#4004

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test with cms-sw/cmsdist#4004

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23241/4719

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4004
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28034/console

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Geometry/HcalCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: f32f63d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23241/28034/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_DEVEL_X_2018-05-17-2300/src/CondCore/CondDB/src/GTSchema.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_DEVEL_X_2018-05-17-2300/src/FWCore/Utilities/interface/GCC11Compatibility.h:10:0,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_DEVEL_X_2018-05-17-2300/src/FWCore/Utilities/interface/Exception.h:41,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_DEVEL_X_2018-05-17-2300/src/CondCore/CondDB/interface/Exception.h:4,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_DEVEL_X_2018-05-17-2300/src/CondCore/CondDB/src/SessionImpl.cc:1:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_DEVEL_X_2018-05-17-2300/src/FWCore/Utilities/interface/Likely.h:14:40: error: expected identifier before 'true'
 #define likely(x) (__builtin_expect(x, true))
                                        ^
/build/cmsbld/jenkins/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/external/boost/1.67.0/include/boost/date_time/special_values_parser.hpp:105:17: note: in expansion of macro 'likely'
     static bool likely(const string_type& str)
                 ^~~~~~


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28121/console Started: 2018/05/23 08:03

[ianna]

This PR does not need new boost. The missing cmath header is from std and should have been included in any case.

[cmsbuild]

+1
Tested at: f32f63d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23241/28121/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23241/28121/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2901712
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901521
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

+1