Clean up the HGC validation folder structure

[hatakeyamak]

Put HGCAL simhits, digis, and rechits validation folders under the folder HGCAL for clean-up purpose.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23256/4737

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23256/4737/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23256/4737/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23256/4738

[cmsbuild]

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

Validation/HGCalValidation

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @bsunanda, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28095/console Started: 2018/05/22 05:15

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28216/console Started: 2018/05/26 18:30

[cmsbuild]

+1
Tested at: 93623d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23256/28216/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23256/28216/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2897635
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2897442
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 24.633 KiB( 30 files compared)
• DQMHistoSizes: changed ( 20034.0,... ): 485700.262 KiB HGCAL/HGCalSimHitsV
• DQMHistoSizes: changed ( 20034.0,... ): -482509.610 KiB HGCalSimHitsV/HitValidation
• DQMHistoSizes: changed ( 20034.0,... ): -2026.888 KiB HGCalSimHitsV/HGCalEESensitive
• DQMHistoSizes: changed ( 20034.0,... ): 1069.519 KiB HGCAL/HGCalRecHitsV
• DQMHistoSizes: changed ( 20034.0,... ): -870.190 KiB HGCalSimHitsV/HGCalHESiliconSensitive
• DQMHistoSizes: changed ( 20034.0,... ): 667.113 KiB HGCAL/HGCalDigisV
• DQMHistoSizes: changed ( 20034.0,... ): -575.171 KiB HGCalRecHitsV/HGCalEESensitive
• DQMHistoSizes: changed ( 20034.0,... ): -358.355 KiB HGCalDigiV/HGCalEESensitive
• DQMHistoSizes: changed ( 20034.0,... ): -288.739 KiB HGCalSimHitsV/HCal
• DQMHistoSizes: changed ( 20034.0,... ): -246.970 KiB HGCalRecHitsV/HGCalHESiliconSensitive
• DQMHistoSizes: changed ( 20034.0 ): ...
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

+1