Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HipPy alignment algorithm improvements #23302

Merged
merged 19 commits into from Jul 17, 2018

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented May 23, 2018

Backport of #23301

Collected improvements from @usarica over the last year:

  • Resurrecting some old code (getByLabel --> getByToken, etc.) in RecoTracker/TrackProducer to fit track with vertex constraints
  • Add the option to use these constraints in HipPy alignment
  • More monitoring variables saved by HipPy
  • interface stuff, like proxy forwarding

(Note the branch name is pretty old, but we've been merge-topicing this for a while and using it for alignment without any problems.)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2018

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_10_1_X.

It involves the following packages:

Alignment/CommonAlignment
Alignment/HIPAlignmentAlgorithm
RecoTracker/TrackProducer

@perrotta, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @lpernie can you please review it and eventually sign? Thanks.
@pakhotin, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @mschrode, @ebrondol, @rovere, @tlampen, @gpetruc, @mmusich, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 5, 2018

comments from master version of this PR will be applicable here as well : #23301 (review)

@arunhep
Copy link
Contributor

arunhep commented Jun 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28486/console Started: 2018/06/05 15:36

@perrotta
Copy link
Contributor

+1

  • Identical commit-wise and code-wise to HipPy alignment algorithm improvements #23301 in the master
  • This is the code which is currently running for the HipPy alignment
  • Bug fixes integrated here do not affect regular CMSSW workflows: no effect on jenkins outputs, as expected

@lpernie
Copy link
Contributor

lpernie commented Jul 2, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29132/console Started: 2018/07/16 22:31

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23302/29132/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2523451
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2523274
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1376cca into cms-sw:CMSSW_10_1_X Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants