New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HipPy alignment algorithm improvements #23302
HipPy alignment algorithm improvements #23302
Conversation
…with cms-merge-topic
A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_10_1_X. It involves the following packages: Alignment/CommonAlignment @perrotta, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
comments from master version of this PR will be applicable here as well : #23301 (review) |
please test |
The tests are being triggered in jenkins. |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Backport of #23301
Collected improvements from @usarica over the last year:
getByLabel
-->getByToken
, etc.) in RecoTracker/TrackProducer to fit track with vertex constraints(Note the branch name is pretty old, but we've been
merge-topic
ing this for a while and using it for alignment without any problems.)