Backport fixes for simulation of long lived exotics

[civanch]

This is a back-port of developments/fixes accumulated in 10_2 for simulation of long-lived exotic particles. This update is needed for the multi-threaded mode and for cases when long lived SUSY particle decay outside vacuum chamber.

Some modifications triggered by code-checks are also back-ported.

Mainstream production will not be affected.

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_9_3_X.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Pull request #23310 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28160/console Started: 2018/05/24 15:52

[cmsbuild]

Pull request #23310 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

-1

Tested at: 2f4d290

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23310/28160/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/CustomParticleFactory.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/DummyChargeFlipProcess.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/FullModelHadronicProcess.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/CMSDarkPairProduction.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/FullModelHadronicProcess.cc:6:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/poison/SimG4Core/CustomPhysics/interface/G4ProcessHelper.hh:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/CustomPhysics.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/FullModelHadronicProcess.cc: In member function 'virtual G4bool FullModelHadronicProcess::IsApplicable(const G4ParticleDefinition&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_9_3_X_2018-05-20-0000/src/SimG4Core/CustomPhysics/src/FullModelHadronicProcess.cc:23:19: error: invalid use of incomplete type 'class G4ProcessHelper'


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[kpedro88]

does this need to be tested with an external update?

[cmsbuild]

Pull request #23310 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

@kpedro88 , no, external update is not needed. This type of simulation simply become not possible with multi-threaded mode.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28166/console Started: 2018/05/24 18:17

[cmsbuild]

+1
Tested at: b822146
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23310/28166/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23310/28166/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2624448
• DQMHistoTests: Total failures: 220
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2624051
• DQMHistoTests: Total skipped: 177
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
• Checked 105 log files, 8 edm output root files, 25 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@kpedro88 , @fabiocos , Brian confirm, that this PR is find for them but not urgent. So, please, merge it at the next occasion. They also ask if the same backport should be done for 9_4?

[kpedro88]

I don't think 9_4_X is used for any MC.

[kpedro88]

merge