-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-alca133 Change prescale factor for IsoTrack filter #23343
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23343/4846 |
A new Pull Request was created by @bsunanda for master. It involves the following packages: Calibration/HcalAlCaRecoProducers @cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please see comment here : #23344 (comment) |
@arunhep well, we should have some test before, no? As far as I can see, the short matrix does not seem to probe this change, nothing looks modified in the output. How was it practically tested? |
@bsunanda can provide more details for testing. I dont have means to check it. |
The Filter filters on average 1% of events. So it is difficult to spot changes in o/p size due to the filter. This has been tested outside with larger # of input events and the reduction in data volume is tested.
…________________________________
From: Arun Kumar [notifications@github.com]
Sent: 28 May 2018 19:44
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run2-alca133 Change prescale factor for IsoTrack filter (#23343)
@bsunanda<https://github.com/bsunanda> can provide more details for testing. I dont have means to check it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23343 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzMupO1Rs81BXTS1pbLogwUmnwesdo8ks5t3DdsgaJpZM4UOWYM>.
|
+1 |
Run2-alca134 Backport PR #23343 to reduce o/p rate
Reduces data volume for AlCaReco file by 45% without losing statistics for calibrating scale factor