Run2-alca133 Change prescale factor for IsoTrack filter

[bsunanda]

Reduces data volume for AlCaReco file by 45% without losing statistics for calibrating scale factor

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23343/4846

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28204/console Started: 2018/05/25 19:53

[cmsbuild]

+1
Tested at: 09c369d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23343/28204/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23343/28204/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2901706
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901513
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[arunhep]

please see comment here : #23344 (comment)

[fabiocos]

@arunhep well, we should have some test before, no? As far as I can see, the short matrix does not seem to probe this change, nothing looks modified in the output. How was it practically tested?

[arunhep]

@bsunanda can provide more details for testing. I dont have means to check it.

[bsunanda]

The Filter filters on average 1% of events. So it is difficult to spot changes in o/p size due to the filter. This has been tested outside with larger # of input events and the reduction in data volume is tested.

…

________________________________ From: Arun Kumar [notifications@github.com] Sent: 28 May 2018 19:44 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run2-alca133 Change prescale factor for IsoTrack filter (#23343) @bsunanda<https://github.com/bsunanda> can provide more details for testing. I dont have means to check it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#23343 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzMupO1Rs81BXTS1pbLogwUmnwesdo8ks5t3DdsgaJpZM4UOWYM>.

[fabiocos]

+1