Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTEM Timing detectors: backports for 10_1_X #23352

Merged
merged 62 commits into from Jun 6, 2018

Conversation

forthommel
Copy link
Contributor

backport of #22796
(among others)

This PR backports the following three master/10_2_X PRs for TOTEM vertical timing detectors to be used very soon for the LHC high-β* operations:

This follows the discussion triggered by @fabiocos in #23275.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23352/28443/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498020
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497843
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 7.3 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): 0.004 KiB MessageLogger/Errors
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 5, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented Jun 5, 2018

+1

@ianna
Copy link
Contributor

ianna commented Jun 5, 2018

+1

@civanch
Copy link
Contributor

civanch commented Jun 5, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 85ffe9e into cms-sw:CMSSW_10_1_X Jun 6, 2018
@forthommel forthommel deleted the totemTiming-digi_recHits-10_1_X branch June 8, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants