Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTEM Timing detectors: DQM backports for 10_1_X #23354

Merged
merged 71 commits into from Jun 6, 2018

Conversation

forthommel
Copy link
Contributor

backport of #22915
and also #23240

This PR backports the TOTEM timing detectors DQM features introduced in the 10_2_X development branch. It consists in the backports of the following PRs:

Based on #23352.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2018

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_10_1_X.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
Configuration/StandardSequences
DQM/CTPPS
DQM/Integration
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
DataFormats/CTPPSReco
EventFilter/CTPPSRawToDigi
Geometry/VeryForwardData
RecoCTPPS/Configuration
RecoCTPPS/TotemRPLocal

@perrotta, @civanch, @Dr15Jones, @vazzolini, @kmaeshima, @davidlange6, @arunhep, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @cerminar, @slava77, @ggovi, @vanbesien, @fabiocos, @lpernie can you please review it and eventually sign? Thanks.
@batinkov, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @thomreis, @mmusich, @threus, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@forthommel
Copy link
Contributor Author

Not sure if you prefer a "lighter" backport PR only including the last ~10-15 commits related to the DQM, or if this format ("directly" mergeable after integration of #23352) is any better?

@dmitrijus
Copy link
Contributor

This format is fine and I prefer it (if the commit history is shared, which, in this case, it is).

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2018

+1

@nminafra
Copy link
Contributor

nminafra commented Jun 4, 2018

@perrotta if you want I can do the same commit as in #23352 so that only one merge is necessary

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2018 via email

@nminafra
Copy link
Contributor

nminafra commented Jun 4, 2018

Thanks @perrotta, I'm ready to do it in case. I'll stand by for the moment.

@dmitrijus
Copy link
Contributor

+1

@arunhep
Copy link
Contributor

arunhep commented Jun 5, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented Jun 5, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit a188040 into cms-sw:CMSSW_10_1_X Jun 6, 2018
@forthommel forthommel deleted the totemTiming-DQM-10_1_X branch June 8, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants