New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOTEM Timing detectors: DQM backports for 10_1_X #23354
Conversation
A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_10_1_X. It involves the following packages: CondFormats/CTPPSReadoutObjects @perrotta, @civanch, @Dr15Jones, @vazzolini, @kmaeshima, @davidlange6, @arunhep, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @cerminar, @slava77, @ggovi, @vanbesien, @fabiocos, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Not sure if you prefer a "lighter" backport PR only including the last ~10-15 commits related to the DQM, or if this format ("directly" mergeable after integration of #23352) is any better? |
This format is fine and I prefer it (if the commit history is shared, which, in this case, it is). |
+1
|
I explicitely verified that they can be merged together without rebasing.
Then I'd rather ask @fabiocos what he finds more convenient to speed
up the integration of the whole set: I would say that it can be faster
to collect all needed signatures and merge the two as they are now,
but I am ready to re-sign if it is preferred.
Nicola Minafra <notifications@github.com> ha scritto:
… @perrotta if you want I can do the same commit as in #23352 so that
only one merge is necessary
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#23354 (comment)
|
Thanks @perrotta, I'm ready to do it in case. I'll stand by for the moment. |
+1 |
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will be automatically merged. |
backport of #22915
and also #23240
This PR backports the TOTEM timing detectors DQM features introduced in the
10_2_X
development branch. It consists in the backports of the following PRs:Based on #23352.