Phase2-hgx113 Mapping trigger ID to ROC #23357

bsunanda · 2018-05-28T14:51:41Z

No description provided.

cmsbuild · 2018-05-28T14:52:00Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-05-28T14:54:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23357/4865

cmsbuild · 2018-05-28T14:54:25Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/ForwardDetId

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2018-05-28T15:41:52Z

@cmsbuild Please test

cmsbuild · 2018-05-28T15:42:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28234/console Started: 2018/05/28 17:42

cmsbuild · 2018-05-28T18:01:08Z

+1
Tested at: aa5aae2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23357/28234/summary.html

cmsbuild · 2018-05-28T18:01:11Z

Comparison job queued.

cmsbuild · 2018-05-28T19:59:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23357/28234/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902474
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2902282
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

kpedro88 · 2018-05-28T20:08:02Z

DataFormats/ForwardDetId/interface/HGCSiliconDetIdToROC.h

+
+private:
+
+  std::map<std::pair<int,int>,int>                triggerIdToROC_;


depending on the size of the maps and how they will be used, unordered_map may perform better

Size of the map is not large. Let us optimize later

kpedro88 · 2018-05-28T20:08:55Z

DataFormats/ForwardDetId/src/HGCSiliconDetIdToROC.cc

+	int v = start2[roc];
+	int u = start1[roc][i1];
+	for (int i2=0; i2<cellRows; ++i2) {
+	  cells.emplace_back(std::make_pair(u,v));


make_pair within emplace_back is redundant; just do emplace_back(u,v)
(in the two cases below as well)

kpedro88 · 2018-05-28T20:10:18Z

DataFormats/ForwardDetId/src/HGCSiliconDetIdToROC.cc

+  }
+
+  // key = trigger cell U,V; value = roc #
+  for (auto itr=triggerIdFromROC_.begin(); 


range-based loop

kpedro88 · 2018-05-28T20:10:27Z

DataFormats/ForwardDetId/src/HGCSiliconDetIdToROC.cc

+
+void HGCSiliconDetIdToROC::print() const {
+
+  for (auto itr=triggerIdFromROC_.begin(); itr!=triggerIdFromROC_.end();


range-based loop

kpedro88 · 2018-05-28T20:10:54Z

DataFormats/ForwardDetId/src/HGCSiliconDetIdToROC.cc

+      std::cout << " (" << cell.first << "," << cell.second << ")";
+    std::cout << std::endl;
+  }
+  for (auto itr=triggerIdToROC_.begin(); itr!=triggerIdToROC_.end(); ++itr)


range-based loop

cmsbuild · 2018-05-30T16:46:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23357/4923

cmsbuild · 2018-05-30T16:47:12Z

Pull request #23357 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again.

bsunanda · 2018-05-30T16:49:23Z

@cmsbuild Please test

cmsbuild · 2018-05-30T16:49:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28303/console Started: 2018/05/30 18:50

bsunanda · 2018-05-30T18:54:48Z

@kpedro88 @civanch I updated the PR in view of comments from Chris Seez. Please approve the new PR

cmsbuild · 2018-05-30T19:19:17Z

+1
Tested at: c94ba8d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23357/28303/summary.html

cmsbuild · 2018-05-30T19:19:20Z

Comparison job queued.

cmsbuild · 2018-05-30T21:31:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23357/28303/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902471
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2902280
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

civanch · 2018-05-31T11:03:48Z

+1

bsunanda · 2018-05-31T13:57:55Z

@kpedro88 Please approve this PR

kpedro88 · 2018-05-31T14:29:56Z

+1

cmsbuild · 2018-05-31T14:30:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-05-31T20:50:10Z

+1

Mapping trigger ID to ROC

aa5aae2

cmsbuild added this to the CMSSW_10_2_X milestone May 28, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels May 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2018

cmsbuild added tests-started and removed tests-pending labels May 28, 2018

cmsbuild added tests-approved and removed tests-started labels May 28, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 28, 2018

kpedro88 reviewed May 28, 2018

View reviewed changes

Use comments from Kevin

2c57f06

cmsbuild removed code-checks-approved comparison-available tests-approved labels May 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels May 30, 2018

cmsbuild added tests-started and removed tests-pending labels May 30, 2018

cmsbuild added tests-approved and removed tests-started labels May 30, 2018

cmsbuild added comparison-available and removed comparison-pending labels May 30, 2018

cmsbuild added simulation-approved and removed simulation-pending labels May 31, 2018

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 31, 2018

cmsbuild added orp-approved and removed orp-pending labels May 31, 2018

cmsbuild merged commit 8352622 into cms-sw:master May 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx113 Mapping trigger ID to ROC #23357

Phase2-hgx113 Mapping trigger ID to ROC #23357

bsunanda commented May 28, 2018

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

bsunanda commented May 28, 2018

cmsbuild commented May 28, 2018 •

edited

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

kpedro88 May 28, 2018

bsunanda May 28, 2018

kpedro88 May 28, 2018

kpedro88 May 28, 2018

kpedro88 May 28, 2018

kpedro88 May 28, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

bsunanda commented May 30, 2018

cmsbuild commented May 30, 2018 •

edited

bsunanda commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

civanch commented May 31, 2018

bsunanda commented May 31, 2018

kpedro88 commented May 31, 2018

cmsbuild commented May 31, 2018

fabiocos commented May 31, 2018


		void HGCSiliconDetIdToROC::print() const {

		for (auto itr=triggerIdFromROC_.begin(); itr!=triggerIdFromROC_.end();

Phase2-hgx113 Mapping trigger ID to ROC #23357

Phase2-hgx113 Mapping trigger ID to ROC #23357

Conversation

bsunanda commented May 28, 2018

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

bsunanda commented May 28, 2018

cmsbuild commented May 28, 2018 • edited

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

cmsbuild commented May 28, 2018

kpedro88 May 28, 2018

Choose a reason for hiding this comment

bsunanda May 28, 2018

Choose a reason for hiding this comment

kpedro88 May 28, 2018

Choose a reason for hiding this comment

kpedro88 May 28, 2018

Choose a reason for hiding this comment

kpedro88 May 28, 2018

Choose a reason for hiding this comment

kpedro88 May 28, 2018

Choose a reason for hiding this comment

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

bsunanda commented May 30, 2018

cmsbuild commented May 30, 2018 • edited

bsunanda commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

cmsbuild commented May 30, 2018

civanch commented May 31, 2018

bsunanda commented May 31, 2018

kpedro88 commented May 31, 2018

cmsbuild commented May 31, 2018

fabiocos commented May 31, 2018

cmsbuild commented May 28, 2018 •

edited

cmsbuild commented May 30, 2018 •

edited