fix headers in PhysicsTools/PatAlgos #23370
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23370/4879 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: PhysicsTools/Heppy @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -40,6 +40,9 @@ | |||
| #include "CommonTools/Utils/interface/StringObjectFunction.h" | |||
| #include "DataFormats/Common/interface/ValueMap.h" | |||
| #include "CommonTools/Utils/interface/TMVAZipReader.h" | |||
| #include "DataFormats/PatCandidates/interface/Jet.h" | |||
There was a problem hiding this comment.
Can't these three includes get now removed from PhysicsTools/PatAlgos/plugins/BaseMVAValueMapProducer.cc, then?
|
@mrodozov : please let us know if you plan to clean up the implementation file as suggested in #23370 (review), or if you prefere to let things as they are now instead |
Update on this change request: cms-sw#23370 (review)
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
tests-approved
labels
|
The code-checks are being triggered in jenkins. |
|
please test |
|
@perrotta updated |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23370/5033 |
|
The tests are being triggered in jenkins. |
|
Thank you Mircho!
Then, I won't be shy and I'll ask the same also for #23463 (as well as
from previous #23385)
Mircho Rodozov <notifications@github.com> ha scritto:
… @perrotta updated
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#23370 (comment)
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
|
merge |
Fix headers related to #15248