Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers RecoMuon pkgs #23385

Merged
merged 2 commits into from Jun 7, 2018
Merged

Conversation

mrodozov
Copy link
Contributor

Fix headers related to #15248

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28285/console Started: 2018/05/30 12:29

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

RecoMuon/L3TrackFinder
RecoMuon/MuonIdentification

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23385/28285/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902280
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@@ -21,6 +21,7 @@
#include "FWCore/Framework/interface/global/EDProducer.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "DataFormats/MuonReco/interface/Muon.h"
#include "DataFormats/MuonReco/interface/MuonFwd.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muon.h and MuonFwd.h are repeated in the MuonRefProducer.cc
Would you like to clean up the MuonRefProducer.cc implementation file before merging this PR?

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2018

@mrodozov : please let us know if you plan to clean up the implementation file as suggested in #23385 (review), or if you prefere to let things as they are now instead

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

mrodozov commented Jun 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28492/console Started: 2018/06/05 18:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Pull request #23385 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23385/28492/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902280
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2018

+1

  • Technical
  • Jenkins tests pass

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

+1

@cmsbuild cmsbuild merged commit ad3b647 into cms-sw:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants