New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix headers RecoMuon pkgs #23385
fix headers RecoMuon pkgs #23385
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23385/4903 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: RecoMuon/L3TrackFinder @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -21,6 +21,7 @@ | |||
#include "FWCore/Framework/interface/global/EDProducer.h" | |||
#include "FWCore/ParameterSet/interface/ParameterSet.h" | |||
#include "DataFormats/MuonReco/interface/Muon.h" | |||
#include "DataFormats/MuonReco/interface/MuonFwd.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muon.h and MuonFwd.h are repeated in the MuonRefProducer.cc
Would you like to clean up the MuonRefProducer.cc implementation file before merging this PR?
@mrodozov : please let us know if you plan to clean up the implementation file as suggested in #23385 (review), or if you prefere to let things as they are now instead |
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23385/5043 |
The tests are being triggered in jenkins. |
Pull request #23385 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Fix headers related to #15248