DD4Hep Shapes Validation

[ianna]

• Access to graph from a compact view
• Add complete scenario to validate shapes
• Add configurations to produce TGeo root files
• Add event display configuration to compare the geometries
• Bug fix for shapes conversion

NOTE: Two remaining issues are open:
AIDASoft/DD4hep#395
AIDASoft/DD4hep#396
When they are fixed, we'll need a DD4Hep external update.

Here is how to run it for DD shapes:

cmsRun DetectorDescription/DDCMS/test/python/dumpDDShapes.py
cmsShow -c DetectorDescription/DDCMS/macros/geo.fwc --sim-geom-file cmsDDShapesTest.root

and this is for DD4Hep:

cmsRun DetectorDescription/DDCMS/test/python/testShapes.py
cmsShow -c DetectorDescription/DDCMS/macros/geo.fwc --tgeo-name=world --sim-geom-file cmsDD4HepGeom.root

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23393/4915

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core
DetectorDescription/DDCMS
Fireworks/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28298/console Started: 2018/05/30 16:24

[alja]

+1

[cmsbuild]

+1
Tested at: 9e8bbdb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23393/28298/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23393/28298/summary.html

Comparison Summary:

• You potentially added 1462943 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902471
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902280
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

the tests mentioned in the description run smoothly

[fabiocos]

@ianna this message should be triggered only for debug , either using some #ifdef or the MessageLogger.