Remove unneeded begin/endLumi methods

[schneiml]

Many DQM plugins contain code to watch begin/end lumi transitions, but don't do anything useful there (often just printing a log message, probably because that is part of the sample code). Looking towards concurrent lumisections, watching these transitions is a problem.

• As a first step, this PR removes the unneded code. It should not functionally change anything, except reducing the log output a bit.
• Then, we can evaluate which plugins actually need per-lumi transitions, and enable them only selectively for these plugins in DQMEDAnalyzer.
• Finally, since any one module watching lumi transitions currently blocks concurrent lumisections, we might want to migrate them to some different implementation that allows concurrent lumis.

@Dr15Jones @knoepfel FYI

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23394/4917

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23394/4917/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23394/4917/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[Dr15Jones]

@schneiml Thanks!

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23394/4918

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQM/BeamMonitor
DQM/CastorMonitor
DQM/DTMonitorModule
DQM/EcalPreshowerMonitorModule
DQM/L1TMonitor
DQM/Physics
DQM/PixelLumi
DQM/RPCMonitorClient
DQM/TrackingMonitor
DQM/TrackingMonitorSource
DQMOffline/CalibCalo
DQMOffline/EGamma
DQMOffline/Ecal
DQMOffline/L1Trigger
DQMOffline/Lumi
DQMOffline/Trigger
DQMServices/Components
DQMServices/Examples
HLTriggerOffline/SUSYBSM
SimTracker/SiPhase2Digitizer
Validation/RecoEgamma

@cmsbuild, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @kpedro88, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@rappoccio, @argiro, @fioriNTU, @thomreis, @threus, @acimmino, @kreczko, @hdelanno, @battibass, @makortel, @jhgoh, @HuguesBrun, @drkovalskyi, @trocino, @rociovilar, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @idebruyn, @ebrondol, @mtosi, @dgulhan, @calderona, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28297/console Started: 2018/05/30 16:22

[thomreis]

+1

[cmsbuild]

+1
Tested at: 6bf5d79
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23394/28297/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23394/28297/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902471
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902280
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[kpedro88]

+1

[civanch]

+1

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

technical cleaning of a large block of code