New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CondFormats/HcalObjects compatible with boost 1.64 #23396
Conversation
In boost 1.64 the serialization code that handles boost::array was removed from array.hpp and put into boost_array.hpp.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23396/4924 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondFormats/HcalObjects @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@smuzaffar @fabiocos this should fix the conditions related build failures in the DEVEL_X IB. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@Dr15Jones thanks for the fix |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
In boost 1.64 the serialization code that handles boost::array was
removed from array.hpp and put into boost_array.hpp.