Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD Compact View: Fix Excessive Output #23412

Merged
merged 1 commit into from Jun 1, 2018

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 1, 2018

  • Remove std::cout

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Jun 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28349/console Started: 2018/06/01 10:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Jun 1, 2018

please test

just for check of the output, I will merge it anyway

@fabiocos
Copy link
Contributor

fabiocos commented Jun 1, 2018

@ianna if this printout is useful for debugging, may be it could be triggered by an #ifdef statement, or by using the MessageLogger (although a dependency on that would be introduced in that case), what do you think?

@fabiocos
Copy link
Contributor

fabiocos commented Jun 1, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jun 1, 2018

merge

prevent next IB output files to be flooded by printouts, the fix is trivial
Possible further improvements for debugging/diagnostic can be added in a next IB if needed

@cmsbuild cmsbuild merged commit e32401c into cms-sw:master Jun 1, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23412/28349/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902278
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants