New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD Compact View: Fix Excessive Output #23412
Conversation
ianna
commented
Jun 1, 2018
- Remove std::cout
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23412/4947 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/Core @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test just for check of the output, I will merge it anyway |
@ianna if this printout is useful for debugging, may be it could be triggered by an #ifdef statement, or by using the MessageLogger (although a dependency on that would be introduced in that case), what do you think? |
+1 |
merge prevent next IB output files to be flooded by printouts, the fix is trivial |
Comparison job queued. |
Comparison is ready Comparison Summary:
|