Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD4Hep: Angular Algorithm #23418

Merged
merged 2 commits into from Jun 5, 2018
Merged

DD4Hep: Angular Algorithm #23418

merged 2 commits into from Jun 5, 2018

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 1, 2018

  • Port DD Angular algorithm
  • Add Magnetic field geometry configuration

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jun 1, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23418/4958

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jun 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28370/console Started: 2018/06/01 17:32

@ianna ianna closed this Jun 1, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

+1
Tested at: 51e38b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23418/28370/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23418/28370/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902279
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@ianna ianna reopened this Jun 4, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Jun 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23418/4997

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28425/console Started: 2018/06/04 16:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Pull request #23418 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

+1
Tested at: dd66a18
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23418/28425/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Jun 4, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23418/28425/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902279
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 5, 2018

+1

affecting only new DDCMS geometry package

@cmsbuild cmsbuild merged commit 0446b10 into cms-sw:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed geometry-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianna @cmsbuild @fabiocos