Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch hierarchyconstraints to CMSSW_5_3_X #2342

Merged

Conversation

frmeier
Copy link
Contributor

@frmeier frmeier commented Feb 6, 2014

This patch has been prepared by Gero Flucke some time ago, see https://twiki.cern.ch/twiki/bin/viewauth/CMS/TkAlignmentLegacyThoughts, first topic. Testing happened on CMSSW_4_4_5. Results were presented in the alignment meeting of Oct 31, 2013, where the modifications got blessed. See https://twiki.cern.ch/twiki/bin/viewauth/CMS/TkAlPullReq201401 for more details and link to the presentation.
This is an outstanding issue since months that was not put into git.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

A new Pull Request was created by @frmeier (Frank Meier) for CMSSW_5_3_X.

Patch hierarchyconstraints

It involves the following packages:

Alignment/CommonAlignmentParametrization

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Feb 21, 2014

@cmsbuild @smuzaffar
Please run the tests. It is a back port from PR 2370 (already in in 71X).

@rcastello
Copy link

Can @cmsbuild @smuzaffar please run the test? This is a backport of something already merged in 71X via the PR #2370

@rcastello
Copy link

+1
(provided jenkins agrees)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+tested

smuzaffar added a commit that referenced this pull request Mar 5, 2014
Patch hierarchyconstraints to CMSSW_5_3_X
@smuzaffar smuzaffar merged commit fa41903 into cms-sw:CMSSW_5_3_X Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants