Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in IndexIntoFileItrImpl::firstEventEntryThisLumi #23424

Merged
merged 1 commit into from Jun 2, 2018

Commits on Jun 1, 2018

  1. Bug fix in IndexIntoFileItrImpl::firstEventEntryThisLumi

    As far as I know no one has ever hit this bug.
    An extremely unusual set of circumstances needs
    to exist to hit it. First the function is only
    called when the LuminosityBlockAuxiliary has an
    invalid beginTime and the Framework is trying to
    fix it by getting the time from the first event
    in that lumi. The bug might cause it to get the
    wrong event and there is a remote chance this event
    could be from the wrong run. But for the wrong
    event to be selected, the lumi has to be fragmented
    over multiple lumi entries in the lumi TTree and
    that only happens after after a lumi was split over
    multiple files and then merged together in a noncontiguous
    order. It can also happen running in a mode using
    multiple concurrent luminosity blocks.
    wddgit committed Jun 1, 2018
    Copy the full SHA
    46dd688 View commit details
    Browse the repository at this point in the history