Update L1TdeStage2uGT_cfi.py

[apana]

Update list of algorithms that need to be blacklisted.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23425/4966

[cmsbuild]

A new Pull Request was created by @apana (Leonard Apanasvich) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28382/console Started: 2018/06/01 23:17

[cmsbuild]

-1

Tested at: 4b7fe85

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
714c402
f519fc5
7f15f5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28382/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28382/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28382/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 2 hours.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
714c402
f519fc5
7f15f5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28382/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28382/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28394/console Started: 2018/06/02 12:04

[cmsbuild]

+1
Tested at: 4b7fe85
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28394/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23425/28394/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902471
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902279
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@apana form my understanding, in which test on which data one is supposed to observe an effect from this change?

[thomreis]

Hi @fabiocos
for example the non-centraBX histograms here https://goo.gl/JaaWt2 should get less entries.
The emulator does not handle certain multi BX algos correctly and that leads to data vs. emulator mismatches. The initial list of blacklisted algos was made with the v0.0.1 L1 menu, while the v1.0.0 has added additional multi BX algos.

[fabiocos]

@thomreis thanks, my question is: was this verified? Should we see it for instance by checking workflow 136.855?

[fabiocos]

+1

[thomreis]

Since this is mainly used in the online DQM it is checked in the online playback system before deployment. It could also be verified in the offline workflows as long as there are enough events.