Add 2D plots for the comparison between data and emulator for L1TObjects - L1T&Online DQM - cmssw102X #23434
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23434/4973 |
|
A new Pull Request was created by @pgianneios for master. It involves the following packages: DQM/L1TMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -10,5 +10,6 @@ | |||
| calol2TauCollectionEmul = cms.InputTag("valCaloStage2Layer2Digis"), | |||
| calol2EtSumCollectionData = cms.InputTag("caloStage2Digis", "EtSum"), | |||
| calol2EtSumCollectionEmul = cms.InputTag("valCaloStage2Layer2Digis"), | |||
| monitorDir = cms.untracked.string("L1TEMU/L1TStage2CaloLayer2/L1TdeStage2CaloLayer2") | |||
| monitorDir = cms.untracked.string("L1TEMU/L1TStage2CaloLayer2/L1TdeStage2CaloLayer2"), | |||
| enable2DComp = cms.untracked.bool(False) # When true eta-phi comparison plots are also produced | |||
There was a problem hiding this comment.
You can enable the 2D plots here.
| @@ -72,6 +72,7 @@ | |||
| muonCollection2Title = cms.untracked.string("uGMT emulator"), | |||
| summaryTitle = cms.untracked.string("Summary of comparison between uGMT muons and uGMT emulator muons"), | |||
| verbose = cms.untracked.bool(False), | |||
| enable2DComp = cms.untracked.bool(False), # When true eta-phi comparison plots are also produced | |||
There was a problem hiding this comment.
You can enable the 2D plots here.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23434/4975 |
|
Pull request #23434 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR applies the changes that have been discussed in https://its.cern.ch/jira/browse/CMSLITDPG-166
It introduces a new boolean parameter enable2DComp in:
DQM/L1TMonitor/python/L1TStage2uGMT_cff.py
and
DQM/L1TMonitor/python/L1TdeStage2CaloLayer2_cfi.py
which can be set to True for drawing 2D eta-phi mismatch plots for the comparison of two collections of L1TOblects.
When enable2DComp=True in DQM/L1TMonitor/python/L1TStage2uGMT_cff.py then 2D plots will be produced for Muon Collections and when enable2DComp=True in DQM/L1TMonitor/python/L1TdeStage2CaloLayer2_cfi.py then 2D plots will be produced for Jet, EGs and Tau collections.