Add filter to count pixel tracks for beta star 90m run #23437
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23437/4974 |
|
A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for master. It involves the following packages: HLTrigger/special @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@JanFSchulte do you need the |
| bool accept = (numTracks >= min_pixelTracks_); | ||
| if(max_pixelTracks_ > 0) | ||
| accept &= (numTracks <= max_pixelTracks_); | ||
| std::cout << numTracks << std::endl; |
There was a problem hiding this comment.
No cout, please use a LogDeug or LogInfo.
|
This filter does not use the functionality of an HLTFilter, so should be a normal EDFilter. |
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23437/5017 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23437/5017/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23437/5018 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23437/5019 |
|
Pull request #23437 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@JanFSchulte |
|
Comparison is ready Comparison Summary:
|
|
@Martin-Grunewald See #23485 for the backport. |
|
@JanFSchulte @Martin-Grunewald where is this filter effectively tested? |
|
@fabiocos studies using this filter have been shown at the TSG last week https://indico.cern.ch/event/733179/contributions/3024006/attachments/1658757/2656741/CMSTOTEM_TSGmeeting_30May2018_Robert.pdf slide 6ff The layer counting works as expected and the thresholds are being tuned. |
|
+1 |
Adds a filter to count pixel tracks at HLT needed for high beta star run.