Fix bug that prevents putting a long long or unsigned long long into an event. #2344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frank Golf discovered that, in 7_0_X, one could not insert an EDProduct of type unsigned long long into an event.
This was due to a bug in FWCore/Utilities/src/TypeWithDict.cc which was a typo on two consecutilve lines that
was likely a cut and paste error when the code was written.
This is a very safe fix. If it is not fixed, not only will EDProducts of (unsigned) long long not be able to be put into an event, but there may be other problems, such as using views to look at collections of long long.
This bug was introduced in 7_0_X. It does not affect prior release cycles.
This bug is ROOT 5 specific. While this fix should be carried forward into 7_1_X, it cannot be carried forward to 7_1_ROOT6_X, because TypeWithDict.cc is totally different there.
A unit test has been enhanced so that this problem would have been found. A separate pull request to 7_1_X will be issued for the unit test because, unlike this fix, the unit test should be carried forward into 7_1_ROOT6_X.