Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that prevents putting a long long or unsigned long long into an event. #2344

Merged
merged 1 commit into from Feb 10, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 6, 2014

Frank Golf discovered that, in 7_0_X, one could not insert an EDProduct of type unsigned long long into an event.
This was due to a bug in FWCore/Utilities/src/TypeWithDict.cc which was a typo on two consecutilve lines that
was likely a cut and paste error when the code was written.

This is a very safe fix. If it is not fixed, not only will EDProducts of (unsigned) long long not be able to be put into an event, but there may be other problems, such as using views to look at collections of long long.

This bug was introduced in 7_0_X. It does not affect prior release cycles.

This bug is ROOT 5 specific. While this fix should be carried forward into 7_1_X, it cannot be carried forward to 7_1_ROOT6_X, because TypeWithDict.cc is totally different there.

A unit test has been enhanced so that this problem would have been found. A separate pull request to 7_1_X will be issued for the unit test because, unlike this fix, the unit test should be carried forward into 7_1_ROOT6_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Fix bug that prevents putting a long long or unsigned long long into an event.

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2344/8/summary.html

@nclopezo
Copy link
Contributor

nclopezo commented Feb 7, 2014

Seems like there are still DAS issues
I will start the tests again

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

nclopezo added a commit that referenced this pull request Feb 10, 2014
FWCore/Utilities Fixes -- Fix bug that prevents putting a long long or unsigned long long into an event.
@nclopezo nclopezo merged commit fc8d4ba into cms-sw:CMSSW_7_0_X Feb 10, 2014
@wmtan wmtan deleted the FixLongLongBug branch February 10, 2014 15:28
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants