Muon reco modification for 2018 heavy ion era

[goni-zz]

this PR includes pt threshold in muons1stStep module for the 2018 heavy ion era.

• change the minPt from 0.5 to 0.8 same as HI setup.
  The modification affects timing reduction in reconstruction with HI custom

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23443/4982

[cmsbuild]

A new Pull Request was created by @goni (Geonhee Oh) for master.

It involves the following packages:

RecoMuon/MuonIdentification

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28437/console Started: 2018/06/04 17:30

[cmsbuild]

+1
Tested at: ef5e103
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23443/28437/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23443/28437/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902471
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902279
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #23443 ef5e103

• code changes are in line with the PR description; the changes affect only Run2_2018_pp_on_AA
• jenkins tests pass (wf 158.0 using Run2_2018_pp_on_AA was not run)
• local tests with 200 events in wf 158.0 show expected behavior.
  • CPU time in muons1stStep is down from 0.70 s/ev to 0.56 s/ev; however this is balanced out by some minor increases in a few PF modules which now treat the previously muon tracks as hadrons [this increase may be partly random though]
  • The reduction in the number of muons is pretty small because most [fake] muons are at higher pt (see a PF muon pt plot below).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1