Fix the length of the string buffer to accommodate the "new format" of the HCAL DetId

[fwyzard]

Reported by GCC 7 -Werror=format-overflow:

src/DQM/HcalCommon/src/HashFunctions.cc: In function 'std::__cxx11::string hcaldqm::hashfunctions::name_HFPMiphi(const HcalDetId&)':
src/DQM/HcalCommon/src/HashFunctions.cc:251:15: error: '%d' directive writing between 1 and 4 bytes into a region of size 3 [-Werror=format-overflow=]
   std::string name_HFPMiphi(HcalDetId const& did)
               ^~~~~~~~~~~~~
src/DQM/HcalCommon/src/HashFunctions.cc:251:15: note: directive argument in the range [0, 1023]
src/DQM/HcalCommon/src/HashFunctions.cc:254:11: note: 'sprintf' output between 9 and 12 bytes into a destination of size 10
    sprintf(name, "HF%siphi%d", did.ieta()>0 ? "P" : "M", did.iphi());
    ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23471/5015

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28452/console Started: 2018/06/04 23:16

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQM/HcalCommon

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@DryRun, @deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: f61bc2b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23471/28452/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23471/28452/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902471
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902279
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1