Additional EMTF plots for Single Muon Quality tracks. Reorganization … #23481
Conversation
…of EMTF page modified: DQM/L1TMonitor/interface/L1TStage2EMTF.h modified: DQM/L1TMonitor/src/L1TStage2EMTF.cc
|
@chadfreer, CMSSW_10_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23481/5031 |
|
A new Pull Request was created by @chadfreer (Chad) for master. It involves the following packages: DQM/L1TMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
DQM/L1TMonitor/src/L1TStage2EMTF.cc
Outdated
| emtfTrackPhiHighQuality->Fill(phi_glob_rad); | ||
| } | ||
| emtfTrackOccupancyHighQuality->Fill(eta, phi_glob_rad); | ||
| if (Track->Pt()>=22) { |
There was a problem hiding this comment.
sorry, would not be better to have the definition of a constant somewhere, isnetad of magic numbers popping-up in the middle of the code?
There was a problem hiding this comment.
I have added a second commit with int definition for track quality and track pt thresholds.
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23481/5041 |
|
Pull request #23481 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
Hi @chadfreer |
|
Backport for 10_1_X: #23593 |
…of EMTF page