Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L1T][DQMOffline] Minor adjustments to Jets & energy sums plots #23493

Merged
merged 7 commits into from Jun 20, 2018

Conversation

kreczko
Copy link
Contributor

@kreczko kreczko commented Jun 5, 2018

The 4th and final part of https://its.cern.ch/jira/browse/CMSLITDPG-588.
It implements:

  • fixed jet matching (in case of two jets with exactly the same dR)
  • TProfile handling for comparison harvester
  • increased ranges for φ resolution plots (energy sums)
  • label fixes
  • using DQMGenericClient for efficiency harvesting

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28498/console Started: 2018/06/05 21:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23493/28498/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902471
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902279
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12.186 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1330.0 ): 12.186 KiB L1T/L1TObjects
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@thomreis
Copy link
Contributor

thomreis commented Jun 6, 2018

+1

@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@kreczko kreczko force-pushed the kreczko-issue-CMSLITDPG-588-part4 branch from 4464c9a to a4cff5d Compare June 6, 2018 11:52
@kreczko
Copy link
Contributor Author

kreczko commented Jun 12, 2018

@fabiocos Done. It is really annoying that a rebase triggers the whole approval procedure again.
Oh, well ;)

@thomreis @dmitrijus please sign again

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #23493 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again.

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28639/console Started: 2018/06/12 17:18

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23493/28639/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902004
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901813
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 14.246 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1330.0 ): 14.246 KiB L1T/L1TObjects
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@thomreis
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@jfernan2 @dmitrijus could you please check again and sign it in case?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ff78b6a into cms-sw:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants