New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L1T][DQMOffline] Minor adjustments to Jets & energy sums plots #23493
[L1T][DQMOffline] Minor adjustments to Jets & energy sums plots #23493
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23493/5050 |
A new Pull Request was created by @kreczko (Luke Kreczko) for master. It involves the following packages: DQMOffline/L1Trigger @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Your PR is unmergeable. Please have a look and possibly rebase it. |
4464c9a
to
a4cff5d
Compare
@fabiocos Done. It is really annoying that a rebase triggers the whole approval procedure again. @thomreis @dmitrijus please sign again |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23493/5157 |
Pull request #23493 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@jfernan2 @dmitrijus could you please check again and sign it in case? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The 4th and final part of https://its.cern.ch/jira/browse/CMSLITDPG-588.
It implements:
DQMGenericClient
for efficiency harvesting