Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE5DPixel10 geometry fixes for SLHC8 #2352

Conversation

davidlange6
Copy link
Contributor

changes needed to make be5d and be5dpixel10 consistent again given changes in hcal geometry between slhc6 and slhc7 - now the be5dpixel10 geometry will run gen-sim

…anges in hcal geometry between slhc6 and slhc7 - now the be5dpixel10 geometry will run gen-sim
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

A new Pull Request was created by @davidlange6 for CMSSW_6_2_X_SLHC.

BE5DPixel10 geometry fixes for SLHC8

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Feb 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

This one passes the upgrade tests with only the currently documented failures.

@mark-grimes
Copy link

merge

Tests 3300, 3400, 4100, 4400, 40001, 50002, 60002, 4502, 4500, 5001 and 15001 all pass; as does 3400 with combinedCustoms.cust_2019WithGem.
Didn't try 60001 or 50001 because these fail with known errors.

cmsbuild added a commit that referenced this pull request Feb 14, 2014
…calChanges

BE5DPixel10 geometry fixes for SLHC8
@cmsbuild cmsbuild merged commit b00f52b into cms-sw:CMSSW_6_2_X_SLHC Feb 14, 2014
@mark-grimes
Copy link

P.S. I also tested with the command below and it worked fine.

cmsDriver.py FourMuPt_1_200_cfi --conditions auto:upgradePLS3 -n 10 --eventcontent FEVTDEBUG --relval 9000,300 -s GEN,SIM --datatier GEN-SIM --beamspot Gauss --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_phase2_BE5DPixel10D --geometry ExtendedPhase2TkBE5DPixel10D --magField 38T_PostLS1 --fileout file:step1.root

@mark-grimes
Copy link

P.P.S. When I say it worked fine, it runs without crashing. There are a few of these error messages printed before the first event:

%MSG-e CmsTrackerDiskBuilder:  OscarProducer:g4SimHits@beginRun  14-Feb-2014 20:15:17 CET Run: 1
ERROR, The Total Number of Blade in one disk is 34; configured 56
%MSG

Don't know if that's an issue.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13624/console

@cmsbuild
Copy link
Contributor

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
spec files added for tinyxml external
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants