DD: Fix gcc 8 Warning #23526
DD: Fix gcc 8 Warning #23526
Conversation
ianna
commented
Jun 8, 2018
ianna
commented
- No need for a try block
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23526/5104 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/RegressionTest @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
| } | ||
| } | ||
| return result_; | ||
| std::cout << std::endl; |
There was a problem hiding this comment.
minor thing: what's the purpose of this line?
There was a problem hiding this comment.
it's there to have an extra line for a nicer output.
|
+1 |
