GEM realistic digitiser #23530
GEM realistic digitiser #23530
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23530/5111 |
|
A new Pull Request was created by @tt8888tt (dajeong jeon) for master. It involves the following packages: SimMuon/GEMDigitizer @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| const LocalPoint& hit_entry(simHit->entryPoint()); | ||
| const LocalPoint& hit_exit(simHit->exitPoint()); | ||
|
|
||
| float hit_entry_smeardX = hit_entry.x()-fabs(CLHEP::RandGaussQ::shoot(0, resolutionX_)); |
There was a problem hiding this comment.
use std::abs() instead of fabs()
There was a problem hiding this comment.
I've fixed and pushed
|
|
||
| float hit_entry_smeardX = hit_entry.x()-fabs(CLHEP::RandGaussQ::shoot(0, resolutionX_)); | ||
| float hit_exit_smeardX = hit_exit.x()+fabs(CLHEP::RandGaussQ::shoot(0, resolutionX_)); | ||
| if (hit_entry.x()>hit_exit.x()) { |
There was a problem hiding this comment.
You could put the above two statements in an else block after this to reduce unneeded random number calls
There was a problem hiding this comment.
you're right, I also have fixed it and pushed
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23530/5112 |
|
Pull request #23530 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23530/5213 |
|
Pull request #23530 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
It looks that RPC is not not changed any more, so the correct engine seems to be used now |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Update of the GEM digitiser
More realistic digi cluster distribution matching test beam results.
https://indico.cern.ch/event/734135/contributions/3027758/attachments/1663982/2667113/rechit_cluster_size_per_ieta.pdf
@jshlee