Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable [[cms::...]] attributes while building with nvcc #23548

Merged
merged 1 commit into from Jun 12, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 11, 2018

Compiling with nvcc/cicc prints multiple messages like

warning: attribute namespace "cms" is unrecognized

As those attributes are only used by the clang static checker, we can safely disable them when compiling with nvcc/cicc.

Compiling with nvcc/cicc prints multiple messages like

> warning: attribute namespace "cms" is unrecognized

As those attributes are only used by the clang static checker, we can safely disable them when compiling with nvcc/cicc.
@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 11, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28605/console Started: 2018/06/11 10:57

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23548/28605/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2901844
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901629
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.64 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 4.53,... ): -0.328 KiB AlCaReco/SiStripCalMinBias
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@fwyzard @Dr15Jones I would assume that the DQM differences are unrelated to this PR

@smuzaffar I see a number of errors reported into the new BuildWarning section, those reproted do not directly seem related to this PR, just everything is recompiled. No label is set here, is this finally the desired behaviour?
And at the end of the Compilation log file I see an error that seems to come from the parsing script:

All python modules compiled
Plugins of all types refreshed.
gmake[1]: Leaving directory '/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-10-2300'
++ /build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py --logDir /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_2_X_2018-06-10-2300/tmp/slc6_amd64_gcc630/cache/log/src
analyzed 981 log files in 5.0400249958 sec.
found 10 errors and warnings in total, by type:
compWarning : 2 in 1 packages
ignoreWarning : 8 in 2 packages
found 978 packages without errors/warnings.
found 3 packages with errors or warnings, 3 with warnings only.
Traceback (most recent call last):
File "/build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py", line 520, in
sys.exit(main(sys.argv))
File "/build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py", line 512, in main
lfa.report()
File "/build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py", line 193, in report
self.makeHTMLSummaryPage()
File "/build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py", line 289, in makeHTMLSummaryPage
link = ' '+pkg.name()+' '+self.tagList[pkg.name()]+' '
KeyError: 'BigProducts/Simulation'
++ true

  • echo ALL_OK
    ALL_OK

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 12, 2018

@fabiocos , cmsbot should have set the warning label but as buildLogAnalyzer.py failed that is why label was not set. I have fixed this in cms-bot.
Anyway, warnings in this case are already there in IB. So please ignore these warnings.
#23514 is suppose to fix these warnings.

@Dr15Jones
Copy link
Contributor

@fabiocos I do not see any way this change could have caused changes in the DQM comparisons.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e40f1d into cms-sw:master Jun 12, 2018
@fwyzard fwyzard deleted the disable_cms_attributes_for_nvcc branch July 5, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants