New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable [[cms::...]] attributes while building with nvcc #23548
Disable [[cms::...]] attributes while building with nvcc #23548
Conversation
Compiling with nvcc/cicc prints multiple messages like > warning: attribute namespace "cms" is unrecognized As those attributes are only used by the clang static checker, we can safely disable them when compiling with nvcc/cicc.
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23548/5136 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
@fwyzard @Dr15Jones I would assume that the DQM differences are unrelated to this PR @smuzaffar I see a number of errors reported into the new BuildWarning section, those reproted do not directly seem related to this PR, just everything is recompiled. No label is set here, is this finally the desired behaviour?
|
@fabiocos I do not see any way this change could have caused changes in the DQM comparisons. |
+1 |
Compiling with nvcc/cicc prints multiple messages like
As those attributes are only used by the clang static checker, we can safely disable them when compiling with nvcc/cicc.