[10.1.X] Bug fixed in SiStripBadComponentInfo

[mmusich]

backport of #23554

Greetings,
this PR implements a bug-fix in SiStripBadComponentInfo.cc where bad fiber histogram never got filled (same a proposed in #23491).
In addition for what concerns the addition of bad components from FED errors, this PR is implements a fix via cloning the siStripQualityESProducer and then modifying the attributes instead of just changing the attributes from the imported module.
Tested against the regular workflow (non-DQM based) and found perfect agreement.
@suchandradutta @fioriNTU @jandrea @arossi83

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_1_X.

It involves the following packages:

DQM/SiStripMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@hdelanno, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from [10.2.X] Bug fixed in SiStripBadComponentInfo #23554

[mmusich]

type bug-fix

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28628/console Started: 2018/06/11 18:45

[cmsbuild]

+1
Tested at: 1d60765
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23555/28628/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23555/28628/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2522539
• DQMHistoTests: Total failures: 43
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2522320
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[mmusich]

dear @jfernan2, any objection to signing this backport of #23554?
The same changes have been merged in the master branch and included in the CMSSW_10_2_X_2018-06-12-2300 IB, where they don't seem to cause troubles.
It would be desirable to have this fix in production as soon as we restart taking data after the TS, since there are other potential downstream workflows in data certification that can profit of this.
Thanks,
Marco

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

tested in Configuration/DataProcessing on 2018B express and prompt