Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 x photon #2358

Merged
merged 6 commits into from Feb 14, 2014
Merged

70 x photon #2358

merged 6 commits into from Feb 14, 2014

Conversation

monttj
Copy link
Contributor

@monttj monttj commented Feb 7, 2014

Back-port to 70X for following items in 71X.

  1. Add access functions for PF isolation to pat::Photon
  2. Add PF isolation to PAT leptons
  3. Remove some obsolete integration tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

A new Pull Request was created by @monttj (Tae Jeong Kim) for CMSSW_7_0_X.

70 x photon

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link

vadler commented Feb 7, 2014

+1
This is a backport of #2345 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

nclopezo added a commit that referenced this pull request Feb 14, 2014
@nclopezo nclopezo merged commit 4b936fe into cms-sw:CMSSW_7_0_X Feb 14, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #2358 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants