Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DDLVector problem with boost 1.67 #23592

Merged
merged 7 commits into from Jun 17, 2018
Merged

Fix DDLVector problem with boost 1.67 #23592

merged 7 commits into from Jun 17, 2018

Commits on Jun 15, 2018

  1. Removed the use of boost::spirit 

    With boost 1.67, the parser was no longer ignoring spaces at the
end of a Vector. Given the version of boost::spirit being used
was the deprecated one, it was replaced with a simple algorithm.
    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    9654e6a View commit details
    Browse the repository at this point in the history

  2. Avoid unnecessary DDLGlobalRegistry calls 

    When parsing the elements of a Vector, we already know which
DDLVector to use (it is 'this').
    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    b3d1dc8 View commit details
    Browse the repository at this point in the history

  3. Avoid unnecessary DDLGlobalRegistry calls in DDLMap

    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    3ee8aba View commit details
    Browse the repository at this point in the history

  4. Removed the need for the DDLGlobalRegistry singleton 

    Now the DDLElementRegistry is owned by the DDLParser and passed
down to the helper classes which need it.
    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    2389ad4 View commit details
    Browse the repository at this point in the history

  5. Removed the use of a ClhepEvaluator singleton in DDLElementRegistry 

    The initialization of a ClhepEvaluator does not appear to be very
CPU intensive therefore there is no critical need to have only
one in the system.
This change should makes DDLElementRegistry thread-friendly.
    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    07aa690 View commit details
    Browse the repository at this point in the history

  6. Removed the use of ClhepEvaluator as a Singleton 

    The ClhepEvaluator is now just used locally as part of the group
of objects which need it.
    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    f8dfba2 View commit details
    Browse the repository at this point in the history

  7. Make sure DDConstants get filled 

    Once the expression pass has finished, we force the update of the
DDConstants from the ClhepEvaluator being used.
    @Dr15Jones
    Dr15Jones committed Jun 15, 2018
    Copy the full SHA
    f94ca14 View commit details
    Browse the repository at this point in the history