Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default cfg track assoc 70 x #2360

Merged

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Feb 7, 2014

Propagate the changes from the new TrackingParticles to the trackingParticleRecoTrackAsssociation and the V0 validator. Also, use the (now faster) trackingParticleRecoTrackAsssociation in the MultiTrackValidator so that a further speed gain is achieved.
On events with PU~20 (runTheMatrix 202.0) it reduced the time of trackingParticleRecoTrackAsssociation by 94% (!) and of trackValidator by 20%.
The output should be unchanged.

For 70X, 71X and 620SHLCX

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2014

A new Pull Request was created by @cerati for CMSSW_7_0_X.

Change default cfg track assoc 70 x

It involves the following packages:

SimTracker/TrackAssociation
Validation/RecoTrack
Validation/RecoVertex

@civanch, @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @mdhildreth, @deguio, @Degano can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Feb 7, 2014

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Feb 10, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2360/19/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@deguio
Copy link
Contributor

deguio commented Feb 11, 2014

@cmsbuild
the errors are not related to the development

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2360/22/summary.html

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

sorry… my mistake - we agreed to take this one for 710pre3 first

@ktf ktf modified the milestones: Next CMSSW_7_0_X release, CMSSW_7_0_0 Feb 16, 2014
nclopezo added a commit that referenced this pull request Feb 19, 2014
Validation -- Change default cfg track assoc 70 x
@nclopezo nclopezo merged commit 4fa3ec2 into cms-sw:CMSSW_7_0_X Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants