Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecal shape db #23600

Merged
merged 10 commits into from Jul 24, 2018
Merged

Ecal shape db #23600

merged 10 commits into from Jul 24, 2018

Commits on Jul 4, 2018

  1. ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a… 

    …nd DB configurability#1
    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    b3a228f View commit details
    Browse the repository at this point in the history

  2. ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a… 

    …nd DB configurability#2
    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    3f7f1ac View commit details
    Browse the repository at this point in the history

  3. ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a… 

    …nd DB configurability#3
    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    d2b19a3 View commit details
    Browse the repository at this point in the history

  4. ECAL Pulse Shape in Simulation, supporting sub-nanosecond precision a… 

    …nd DB configurability#4
    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    869540f View commit details
    Browse the repository at this point in the history

  5. code quality checks

    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    d6882f1 View commit details
    Browse the repository at this point in the history

  6. removing using std namespace from header file to comply with the CMSS… 

    …W code style
    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    a5edf40 View commit details
    Browse the repository at this point in the history

  7. removing declarations of basic types from CondFormats/EcalObjects/src… 

    …/classes.h
    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    9ff01a2 View commit details
    Browse the repository at this point in the history

  8. adding unit test for EcalSimPulseShape testSerialization

    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    3f15b8f View commit details
    Browse the repository at this point in the history

  9. implementing comments from Kevin Pedro on the PR

    @theofil
    theofil committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    47750f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2018

  1. addressing missed comments from Kevin Perdo

    @theofil
    theofil committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    9ca9de4 View commit details
    Browse the repository at this point in the history