New ETL geometry with 11 rings based on engineering drawings, add approximate support plate

[fabiocos]

The ETL geometry is updated according to specifications by @lgray from FNAL engineers. The rings have been updated from 9 to 11, and the positions are now according to the provided spreadsheet.
An approximate description of the aluminum support plate is also added, with a 6 mm thick plate between rings and a restricted 3.4 mm plate within rings, in the space in between front and rear modules. The services description in tkLayout has not been modified. The module size now used in 95 x 49 mm.

The numbering scheme code has been adapted accordingly.

The ETL geometry remains free from overlaps (tested with Geant4 code), and the numbering scheme has been reverified with the test code. According to the Geant4 dump of SD positions, the ETL module are correctly placed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23603/5212

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData
Geometry/MTDSimData

The following packages do not have a category, yet:

Geometry/MTDCommonData
Geometry/MTDSimData
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28722/console Started: 2018/06/15 22:57

[fabiocos]

real tests should be done using PhaseII scenarios D24 and D25

[cmsbuild]

+1
Tested at: 0fad1db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23603/28722/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23603/28722/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902004
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901813
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

assign geometry

@smuzaffar apparently I missed to updated the bot for the addition of these packages back in #23126, to be fixed

[cmsbuild]

New categories assigned: geometry

@Dr15Jones,@mdhildreth,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[civanch]

+1

[fabiocos]

@kpedro88 FYI, this is affecting PhaseII geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

assign upgrade
@fabiocos can you please add the new packages to the upgrade category?

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1