Correction of a tag name (Ecal O2O unit test fix)

[depasse]

Realted to the error described in PR #23606

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23610/5229

[cmsbuild]

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28747/console Started: 2018/06/18 22:22

[cmsbuild]

+1
Tested at: e900885
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23610/28747/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23610/28747/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902013
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901822
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

@depasse @ggovi thanks for the prompt reaction. Anyway, why this was working up to Friday evening and it has stopped top do so since then? What has changed to cause this failure?

@ggovi if this is ok for you, could you please sign it?

[depasse]

Hypothesis : this code was created on 17 February.
On Friday, it was the first time that there was a switching Bon -> Boff. So the first time the wrong tag was called.
Giacomo, this code is only for testing purposes, no ? As the O2O in production works well.

[ggovi]

@fabiocos
I think Pierre is right, the code with the wrong tag was previously never invoked.
@depasse
yes this is the validation test. The production script is a different one, no failures on it.

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@depasse thank you for the explanation, it makes sense

[fabiocos]

+1

[boudoul]

Just a small comment to @depasse : Please when you make a PR, make an explicit title - It is not possible to understand from this title if the tag you are changing is an hcal, strips, beamspot , or ecal tag ... The titles of PRs are very important, thank you .

[fabiocos]

@boudoul you are right, this title was bit too generic... I have appended a note

[boudoul]

Thank you @fabiocos !