Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of an ECAL tag name in IB tests (Ecal O2O unit test fix) #23622

Merged
merged 1 commit into from Jun 20, 2018

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jun 19, 2018

Backport of PR #23610
Fixing the name of an Eca tag to fix issue seen in IB tests
On behalf of @depasse

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_10_1_X.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented Jun 19, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28762/console Started: 2018/06/19 15:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23622/28762/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2523210
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2523033
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

tested in master, thanks @boudoul

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 3113354 into cms-sw:CMSSW_10_1_X Jun 20, 2018
@fabiocos fabiocos changed the title Correction of an ECAL tag name in IB tests Correction of an ECAL tag name in IB tests (Ecal O2O unit test fix) Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants