Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra timing report to include user time #23635

Merged
merged 1 commit into from Jun 22, 2018
Merged

Fix extra timing report to include user time #23635

merged 1 commit into from Jun 22, 2018

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jun 21, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23635/5282

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/LHEInterface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28805/console Started: 2018/06/21 19:49

@cmsbuild
Copy link
Contributor

+1
Tested at: b004541
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23635/28805/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a571295
b753792
dfaca38
2eff18f
29cf2ed
fcabd47
506b700
0ad0982
34707d6
ea6281d
8264c58
3e2f367
40ab829
ac4fdbc
a5acde6
5760eba
d8eb3fe
2ae0d27
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23635/28805/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23635/28805/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23635/28805/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10455 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2898355
  • DQMHistoTests: Total failures: 19001
  • DQMHistoTests: Total nulls: 42
  • DQMHistoTests: Total successes: 2879122
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19055.382 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 10824.0,... ): 1793.399 KiB L1T/L1TStage2BMTF
  • DQMHistoSizes: changed ( 10824.0,... ): -534.663 KiB CTPPS/TrackingPixel
  • DQMHistoSizes: changed ( 10824.0,... ): 19.221 KiB L1TEMU/L1TdeStage2BMTF
  • DQMHistoSizes: changed ( 10824.0,... ): 7.375 KiB Generator/Particles
  • DQMHistoSizes: changed ( 250202.181 ): -0.410 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10224.0 ): -0.190 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.617 KiB SiStrip/MechanicalView
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

please test

changes looks unrelated to this PR, now the comparison should be cleaner

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28823/console Started: 2018/06/22 15:50

@cmsbuild
Copy link
Contributor

+1
Tested at: b004541
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23635/28823/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23635/28823/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899538
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899346
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1a82e61 into cms-sw:master Jun 22, 2018
@Dr15Jones Dr15Jones deleted the fixExtraTiming branch June 25, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @alberto-sanchez @fabiocos