Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV #23640

eacoleman · 2018-06-22T04:15:38Z

See #23618.

cmsbuild · 2018-06-22T04:18:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-22T04:21:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23640/5291

slava77 · 2018-06-22T04:23:00Z

RecoBTag/Combined/plugins/DeepFlavourJetTagsProducer.cc

+				//warn if the input is nan
+				if(std::isnan(inputs_[var.name])) {
+					edm::LogWarning("ValueError") 	<< "The required output, " 
+													<< var.name << ", encountered an nan value during TagInfo processing." << endl;


endl is not necessary.
Also the second line indent better be aligned with the first line <<

cmsbuild · 2018-06-22T04:23:01Z

A new Pull Request was created by @eacoleman (Evan Coleman) for master.

It involves the following packages:

RecoBTag/Combined

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-06-22T04:36:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-22T04:39:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23640/5292

cmsbuild · 2018-06-22T04:40:13Z

Pull request #23640 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2018-06-22T04:42:45Z

@cmsbuild please test

cmsbuild · 2018-06-22T04:43:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28813/console Started: 2018/06/22 11:00

cmsbuild · 2018-06-22T12:13:57Z

+1
Tested at: 4a59d78
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23640/28813/summary.html

cmsbuild · 2018-06-22T12:13:59Z

Comparison job queued.

cmsbuild · 2018-07-30T16:37:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-07-30T16:40:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23640/5822

cmsbuild · 2018-07-30T16:40:45Z

Pull request #23640 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

davidlange6 · 2018-07-30T16:42:51Z

please test

cmsbuild · 2018-07-30T16:43:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29568/console Started: 2018/07/30 18:43

cmsbuild · 2018-07-30T19:04:35Z

+1
Tested at: b9e8281
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23640/29568/summary.html

cmsbuild · 2018-07-30T19:04:38Z

Comparison job queued.

cmsbuild · 2018-07-30T20:27:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23640/29568/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2891493
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2891302
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

slava77 · 2018-07-31T16:26:05Z

+1

for #23640 b9e8281

code changes are in line with the PR description and the follow up review. Only LogWarning is added; the rest of the behavior of the code is unchanged.
jenkins tests pass and comparisons with the baseline show that in wf 136.7611 (the only place in all tests) there is a warning message in the expected format:

%MSG-w ValueError:  DeepFlavourJetTagsProducer:pfDeepCSVJetTagsPuppi  30-Jul-2018 19:01:35 CEST Run: 277069 Event: 36217652
The NN encountered 2 nan input TagInfo values and produced 5 nan output values
%MSG

cmsbuild · 2018-07-31T16:26:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-07-31T20:24:56Z

+1

Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV

c11a471

eacoleman mentioned this pull request Jun 22, 2018

BTV: Add warning for NaN DeepCSV values and inputs #23618

Merged

cmsbuild added this to the CMSSW_10_2_X milestone Jun 22, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 22, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 22, 2018

slava77 reviewed Jun 22, 2018

View reviewed changes

Remove endl and fix indentation

4a59d78

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 22, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 22, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2018

cmsbuild removed the tests-started label Jun 22, 2018

cmsbuild added code-checks-pending comparison-pending tests-pending labels Jul 30, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 30, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 30, 2018

cmsbuild added tests-approved and removed tests-started labels Jul 30, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 30, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 31, 2018

slava77 mentioned this pull request Jul 31, 2018

Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV #24147

Merged

cmsbuild added orp-approved and removed orp-pending labels Jul 31, 2018

cmsbuild merged commit c6068e7 into cms-sw:master Jul 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV #23640

Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV #23640

eacoleman commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

slava77 Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

slava77 commented Jun 22, 2018

cmsbuild commented Jun 22, 2018 •

edited

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

davidlange6 commented Jul 30, 2018

cmsbuild commented Jul 30, 2018 •

edited

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

slava77 commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

fabiocos commented Jul 31, 2018

Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV #23640

Add warning for NaN values in DeepFlavourJetTagsProducer for DeepCSV #23640

Conversation

eacoleman commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

slava77 Jun 22, 2018

Choose a reason for hiding this comment

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

slava77 commented Jun 22, 2018

cmsbuild commented Jun 22, 2018 • edited

cmsbuild commented Jun 22, 2018

cmsbuild commented Jun 22, 2018

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

davidlange6 commented Jul 30, 2018

cmsbuild commented Jul 30, 2018 • edited

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

cmsbuild commented Jul 30, 2018

slava77 commented Jul 31, 2018

cmsbuild commented Jul 31, 2018

fabiocos commented Jul 31, 2018

cmsbuild commented Jun 22, 2018 •

edited

cmsbuild commented Jul 30, 2018 •

edited