bug fix for case with SimClusters but no RecHits

[kpedro88]

type bugfix

Followup to #23545. An occasional crash (less than 1% frequency) was observed in private tests. I determined the reason as follows: there can be cases where there are SimClusters but no RecHits. If the SimMapper does not create the corresponding PF clusters in those cases, there is a mismatch in the SimPFProducer. This PR simplifies the determination of the geometry type (using RecHitTools) in order to avoid relying on a RecHit collection that may be empty.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23660/5316

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @mmarionncern, @rovere, @argiro, @cseez, @seemasharmafnal, @pfs, @cbernet, @lgray, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28840/console Started: 2018/06/22 20:53

[cmsbuild]

+1
Tested at: 7034294
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23660/28840/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23660/28840/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899288
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[kpedro88]

+1

[slava77]

+1

for #23660 7034294

• code changes are in line with the PR description and should affect only cases with crashes or otherwise produce the same results
• jenkins tests pass and there are no changes in the comparisons with the baseline

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1