Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlCaRecoMatrix for 2018 #23663

Merged
merged 1 commit into from Jun 25, 2018

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Jun 22, 2018

The PR updates AlCaReco matrix to include 2018 new primary dataset and new AlCaReco;
the AlCaReco matrix in the CMSSW release in 2017 is kept as AlCaRecoMatrix2017

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/AlCa

@arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 22, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28843/console Started: 2018/06/22 21:45

@cmsbuild
Copy link
Contributor

-1

Tested at: 7a48c12

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23663/28843/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
250202.181 step2

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@tocheng
Copy link
Contributor Author

tocheng commented Jun 24, 2018

@arunhep @fabiocos The error of Relval workflow 250202.181 is due to DAS issue:
time="2018-06-22T22:57:37+02:00" level=error msg="DAS QL error" Query="file dataset = /RelValMinBias_13/CMSSW_10_2_0_pre2-101X_upgrade2018_realistic_v7-v1/GEN-SIM" idx=0 msg="unable to parse DAS query"
at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23663/28843/runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log
250202

I also tested this workflow locally, and it ran without failure.

@arunhep Could you please trigger the test again? Thanks.

@arunhep
Copy link
Contributor

arunhep commented Jun 24, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28851/console Started: 2018/06/24 11:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23663/28851/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899288
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 24, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@arunhep
Copy link
Contributor

arunhep commented Jun 24, 2018

@fabiocos it would be good to have it in pre6 if possible. Thanks !

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1dddadb into cms-sw:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants