Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BranchID in DelayedReader #23664

Merged
merged 2 commits into from Jun 23, 2018
Merged

Use BranchID in DelayedReader #23664

merged 2 commits into from Jun 23, 2018

Conversation

Dr15Jones
Copy link
Contributor

Micro-benchmarking showed that using a BranchID instead of a BranchKey was much faster.

@Dr15Jones
Change DelayedReader to use BranchID instead of BranchKey
cda9f91 
Micro-benchmarking showed that switching to the BranchID was substantially faster for lookup than using BranchKey.
Switching to a unordered_map in RootTree is also an improvement.
@Dr15Jones
Removed BranchID from RootTree::addBranch
53502e1 
The function was already getting a BranchDescription which holds the BranchID.
@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jun 22, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23664/5319

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/TFWLiteSelector
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28842/console Started: 2018/06/22 21:23

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1
Tested at: 53502e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23664/28842/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23664/28842/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899480
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899289
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a64348d into cms-sw:master Jun 23, 2018
@Dr15Jones Dr15Jones deleted the useBranchIDinDelayedReader branch June 25, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @fabiocos