update 2018 design GT with pixel 2D temalates

[arunhep]

It should address the this github issue : #23666

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/102X_upgrade2018_design_v5/102X_upgrade2018_design_v3

[cmsbuild]

The code-checks are being triggered in jenkins.

[arunhep]

please test workflow 11224.0,11224.6

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23667/5325

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28853/console Started: 2018/06/24 12:56

[cmsbuild]

A new Pull Request was created by @arunhep (Arun Kumar) for master.

It involves the following packages:

Configuration/AlCa

@arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@tvami @arunhep,
just for my understanding, looks like the denominator and numerator tags are different in the change proposed here. IIUC this means the charge reweighting will be applied and a deteriorarion of performance will follow. Is this the desired outcome for a design GT, which I thought should implement a non irradiated scenario?
Was this discussed elsewhere? What does Tk POG thinks about it?

[arunhep]

@mmusich good point ! Thanks.
@tvami can you confirm please? I will then use same tag for numerator and denominator which should switchoff this correction.

[tvami]

Thanks Marco for pointing to this. Indeed in this case the same tags should be used for num and denom, too. Arun Kumar <notifications@github.com> ezt írta (időpont: 2018. jún. 24., Vas 13:02):

…

@mmusich <https://github.com/mmusich> good point ! Thanks. @tvami <https://github.com/tvami> can you confirm please? I will then use same tag for numerator and denominator which should switchoff this correction. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23667 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE1FrpY_R7Glgzv3BYqwPDWfcqXXbwTTks5t_3HBgaJpZM4U1Ey0> .

[cmsbuild]

The code-checks are being triggered in jenkins.

[arunhep]

please test workflow 11224.0,11224.6

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23667/5326

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28855/console Started: 2018/06/24 17:48

[cmsbuild]

Pull request #23667 was updated. @arunhep, @cerminar, @cmsbuild, @franzoni, @pohsun, @lpernie can you please check and sign again.

[cmsbuild]

+1
Tested at: 31e6add
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23667/28853/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

+1
Tested at: b51893b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23667/28855/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23667/28855/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23667/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018Design_GenSimFull+DigiFull_2018Design+RecoFull_2018Design+HARVESTFull_2018Design
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23667/11224.6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018Design_GenSimFull_heCollapse+DigiFull_heCollapse_2018Design+RecoFull_heCollapse_2018Design+HARVESTFull_heCollapse_2018Design

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899288
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

@arunhep the test looks successful. If the applied record is what really intended in the design scenario, as I understand it is in its latest version, could you please sign. so as I we can remove this issue?

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1