[L1T][DQMOffline] Tau DQM updates (CMSLITDPG-590)

[kreczko]

Fixing issue https://its.cern.ch/jira/browse/CMSLITDPG-590:

• Error bars for efficiency plots. Possibly via the DQMGenericClient module (see muon harvesting). https://its.cern.ch/jira/browse/CMSLITDPG-579
• Drop “events” y axis label for efficiency plots.
• Review binning for 2D L1 vs. offline pT plots and normalise to the bin size.
  • Can keep the binning for now but the bin content should be normalised to the bin area. With the normalisation "(normalised to bin area)" should be added to the histogram title.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23673/5332

[cmsbuild]

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28872/console Started: 2018/06/25 16:40

[cmsbuild]

-1

Tested at: a20effb

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23673/28872/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test DQMTestStandaloneBuildOfDQMStore had ERRORS
---> test DQMFastMatchTest had ERRORS
---> test DQMQualityTestsExample had ERRORS
---> test TestDQMServicesFwkIOScripts had ERRORS
---> test runFastHadd had ERRORS
---> test testSchemaEvolution had ERRORS
---> test runTheWhiteRabbit had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23673/28872/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899287
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 19.459 KiB( 30 files compared)
• DQMHistoSizes: changed ( 1330.0 ): 19.459 KiB L1T/L1TObjects
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[smuzaffar]

please test
cms-bot had an issue with unittests, this should be fixed now.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29001/console Started: 2018/07/04 12:12

[cmsbuild]

+1
Tested at: 2ab3ca7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23673/29001/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2ab3ca7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23673/29001/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23673/29001/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23673/29001/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899289
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 19.459 KiB( 30 files compared)
• DQMHistoSizes: changed ( 1330.0 ): 19.459 KiB L1T/L1TObjects
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[thomreis]

+1

[thomreis]

Hi @kreczko
now that the master points to 10_3_X you might also want to make a PR to the 10_2_X branch.

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1